Skip to content

fix: update session environment UI to allow resetting args and command #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 31, 2025
Merged

fix: update session environment UI to allow resetting args and command #3888

merged 4 commits into from
Oct 31, 2025

Conversation

@leafty
Copy link
Member

@leafty leafty commented Oct 23, 2025 •
edited
Loading

Update the UI to allow resetting args and command for sessions.

See: SwissDataScienceCenter/renku-data-services#1073.

Note: merge after backend update.

@leafty leafty mentioned this pull request Oct 23, 2025
Merged
@leafty leafty marked this pull request as ready for review October 23, 2025 09:02
@leafty leafty requested a review from a team as a code owner October 23, 2025 09:02
@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Oct 29, 2025
lorenzo-cavazzi
lorenzo-cavazzi approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch -- wrong PR sorry

lorenzo-cavazzi
lorenzo-cavazzi requested changes Oct 29, 2025
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I accidentally wrote in the wrong PR -- I'm reviewing this in a sec

lorenzo-cavazzi
lorenzo-cavazzi previously approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

leafty
leafty commented Oct 31, 2025
View reviewed changes
@leafty leafty merged commit 4182b04 into main Oct 31, 2025
16 checks passed
@leafty leafty deleted the leafty/fix-session-env-api branch October 31, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees

@lorenzo-cavazzi lorenzo-cavazzi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leafty @lorenzo-cavazzi